Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ffi): include the scard feature by default #302

Merged
merged 5 commits into from
Oct 8, 2024
Merged

build(ffi): include the scard feature by default #302

merged 5 commits into from
Oct 8, 2024

Conversation

CBenoit
Copy link
Member

@CBenoit CBenoit commented Oct 8, 2024

@CBenoit CBenoit requested review from a team as code owners October 8, 2024 10:18
@CBenoit CBenoit enabled auto-merge (squash) October 8, 2024 10:18
@CBenoit CBenoit changed the title ci: update the tested and built feature set build(ffi): include the scard feature by default Oct 8, 2024
@CBenoit CBenoit force-pushed the ci/update-compiled-feature-set branch from 2e7bce7 to 5efbf47 Compare October 8, 2024 10:50
@CBenoit
Copy link
Member Author

CBenoit commented Oct 8, 2024

@TheBestTvarynka Does enabling scard by default for the ffi crate sounds good to you, or should it stay an option?

Also, the CI is hitting more compilation issues such as:

   Compiling sspi v0.13.0 (/home/runner/work/sspi-rs/sspi-rs)
error[E0308]: arguments to this function are incorrect
   --> ffi/src/winscard/system_scard/context.rs:724:21
    |
724 |                     (self.api.SCardGetStatusChange)(
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
725 |                         self.h_context,
726 |                         timeout,
    |                         ------- expected `u64`, found `u32`
    |
note: expected `*mut ScardReaderState`, found `*mut ScardReaderStateA`
   --> ffi/src/winscard/system_scard/context.rs:727:25
    |
727 |                         states.as_mut_ptr(),
    |                         ^^^^^^^^^^^^^^^^^^^
    = note: expected raw pointer `*mut ScardReaderState`
               found raw pointer `*mut ScardReaderStateA`
help: you can convert a `u32` to a `u64`
    |
726 |                         timeout.into(),
    |                                +++++++

@TheBestTvarynka
Copy link
Collaborator

Also, the CI is hitting more compilation issues such as:

Hm, got it. Let me fix it

@CBenoit CBenoit force-pushed the ci/update-compiled-feature-set branch from b4bed06 to 64993ef Compare October 8, 2024 12:56
@CBenoit
Copy link
Member Author

CBenoit commented Oct 8, 2024

@TheBestTvarynka I rebased on top of master

@TheBestTvarynka TheBestTvarynka mentioned this pull request Oct 8, 2024
Merged
@CBenoit CBenoit force-pushed the ci/update-compiled-feature-set branch from 64993ef to 88a4b95 Compare October 8, 2024 15:27
@CBenoit CBenoit force-pushed the ci/update-compiled-feature-set branch from f105d3a to 2af75c3 Compare October 8, 2024 15:39
@CBenoit
Copy link
Member Author

CBenoit commented Oct 8, 2024

@TheBestTvarynka Looks like there are still a few compilation errors. Can you fix the problems directly on my branch?

@TheBestTvarynka
Copy link
Collaborator

Yes, give a few minutes

@CBenoit CBenoit merged commit 62632fa into master Oct 8, 2024
42 checks passed
@CBenoit CBenoit deleted the ci/update-compiled-feature-set branch October 8, 2024 16:48
@TheBestTvarynka
Copy link
Collaborator

Finally, the CI is happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbstp rbstp rbstp approved these changes

@TheBestTvarynka TheBestTvarynka TheBestTvarynka approved these changes

@thenextman thenextman thenextman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CBenoit @TheBestTvarynka @thenextman @rbstp